Skip to content

Switch github CI jobs to use po4a version 0.67.#1837

Merged
SebKuzminsky merged 1 commit intoLinuxCNC:masterfrom
petterreinholdtsen:po4a-github-0.67
Jul 29, 2022
Merged

Switch github CI jobs to use po4a version 0.67.#1837
SebKuzminsky merged 1 commit intoLinuxCNC:masterfrom
petterreinholdtsen:po4a-github-0.67

Conversation

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator

No description provided.

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator Author

This is caused by a bug in the Debian package of po4a, which is missing a runtime dependency. Once a new version is uploaded to Debian, I'll update the patch and hopefully get it working.

@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 16, 2022

I'm not against it, but what's the motivation for using a super-new version of po4a?

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Jul 16, 2022 via email

@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 16, 2022

How will it affect building documentation with releases from linuxcnc.org that target "older" releases such as debian stable?

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator Author

petterreinholdtsen commented Jul 16, 2022 via email

@SebKuzminsky
Copy link
Copy Markdown
Collaborator

SebKuzminsky commented Jul 16, 2022

I built po4a 0.66 for buster, it's in the deb archive on wlo and it's being used to build the docs in the buildbot. Backporting build-dependencies like this is not new to us, but it's also something we generally try to avoid, because of all the chaos it introduces. In this case i think the benefit of working translation infrastructure makes it worth it.

I'm in favor of merging this, after the build issue gets resolved.

Install using apt install to include any new dependencies.
@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 17, 2022

@SebKuzminsky that's good but it looks like now a higher version is needed again

@petterreinholdtsen
Copy link
Copy Markdown
Collaborator Author

petterreinholdtsen commented Jul 18, 2022 via email

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Jul 18, 2022 via email

@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 22, 2022

@SebKuzminsky will you be able to update po4a on the buildbot a second time? Otherwise, it sounds like our generated docs will be badly broken.

@SebKuzminsky SebKuzminsky merged commit cf2b68d into LinuxCNC:master Jul 29, 2022
@SebKuzminsky
Copy link
Copy Markdown
Collaborator

I'll update the deb archive at wlo and the buildbot mid next week some time.
Thanks @petterreinholdtsen and @silopolis for all your work on our translations and translation infrastructure, and for reporting the issues you find to po4a upstream!

@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Jul 30, 2022 via email

@petterreinholdtsen petterreinholdtsen deleted the po4a-github-0.67 branch August 10, 2022 15:59
@silopolis
Copy link
Copy Markdown
Contributor

silopolis commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants